Differences with protocol version DO NOT MERGE#6
Draft
ibevers wants to merge 2 commits into
Draft
Conversation
Collaborator
|
can you fix anything that should be fixed in the converter as a corresponding PR? for example i think the NaN use case is simply dropping that field (which should also be what happens here). cc: @yibeichan |
Collaborator
|
@satra yes, i just made one ReproNim/reproschema-py#81, I'll let @Evan8456 take a look, if good we merge. |
unders items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created the b2aiprotocol branch to be used so that edits can be quickly made to the auto-converted items for use in the actual protocol. This is just to show the differences between that branch and the pure auto-converted one.